I HAVE A DREAM NEW CallerID Superfecta 2.2.4: THE MODULE

tm1000

Schmoozecom INC/FreePBX
Joined
Dec 1, 2009
Messages
1,360
Reaction score
78
Just as an FYI.

Superfecta will NOT NOT NOT work in FreePBX 2.9
 

tm1000

Schmoozecom INC/FreePBX
Joined
Dec 1, 2009
Messages
1,360
Reaction score
78
Actually the version I have in svn will work.
 

atsak

Guru
Joined
Sep 7, 2009
Messages
2,381
Reaction score
436
The Aastra 6757i expansion model (and perhaps others that use it) doesn't have a drop down item for BLF Xfer. They do support this and so I end up setting these all up manually for customers who like this feature. Whenever convenient it would be helpful to have this. If you need more info pls say so :)
 

Stewart

Guru
Joined
Sep 16, 2009
Messages
603
Reaction score
6
Good, but...

There are 3 search types:
1) accounts
2) accounts and users
3) accounts, users, and contacts

When I drop down the menu and select #3 and hit apply, it sets at accounts, users, and contacts just as it should.

When I drop down the menu and select #2 and hit apply, it sets at accounts and users just as it should.

But when I drop down the menu and select #1 and hit apply, it sets at accounts, users, and contacts - the same as if I hit #3.

My problem is that sometimes the CID isn't returned properly if someone from the account calls and there are several contacts and users in the account for it to attach to. In that case nothing displays on the phone, but it seems to be properly set in the asterisk logs. I'd like to set it to just the account so that it doesn't matter who from the company calls, it only shows the company.

Thanks for the work! I'm just not sure where to check. I see references in source-SugarCRM.php but am not sure if that's the correct place to be looking.
 

Stewart

Guru
Joined
Sep 16, 2009
Messages
603
Reaction score
6
Using this new file has the same results. Selecting the first option and hitting reply leaves the third option as selected.
 

Stewart

Guru
Joined
Sep 16, 2009
Messages
603
Reaction score
6
Modules show:
CID Superfecta 2.2.4 projects.colsolgrp.net Enabled

And I'm using the new php you posted. I see the changes you made were:
$source_param['Search_Type']['option'][1] = 'accounts';
$source_param['Search_Type']['option'][2] = 'accounts and users';
$source_param['Search_Type']['option'][3] = 'accounts, users and contacts';

and the corresponding entries in IF statements.

I've now tried from both FF and IE on 2 computers and the problem hasn't changed.:confused5:

Is that file the one that's even filling in that field? Seems like it's the calling page that isn't accepting correctly. Do I need a reboot?

EDIT: Just rebooted to no avail. I know it's php and reboots shouldn't help, but figured "Why not?"
 

Stewart

Guru
Joined
Sep 16, 2009
Messages
603
Reaction score
6
Before we try anything drastic, I looked at the files and saw this:

lrwxrwxrwx 1 asterisk asterisk 65 Jun 22 2010 source-Send_to_YAC.php -> /var/www/html/admin/modules/superfecta/bin/source-Send_to_YAC.php
-rwxrwxr-- 1 asterisk asterisk 6806 Mar 11 09:02 source-SugarCRM.php
-rwxrwxr-- 1 asterisk asterisk 6704 Mar 11 09:01 source-SugarCRM.php.backup
lrwxrwxrwx 1 asterisk asterisk 70 Jun 22 2010 source-Superfecta_Cache.php -> /var/www/html/admin/modules/superfecta/bin/source-Superfecta_Cache.php
lrwxrwxrwx 1 asterisk asterisk 67 Mar 10 17:59 source-Superpages_AU.php -> /var/www/html/admin/modules/superfecta/bin/source-Superpages_AU.php

Does that seem right?
 

Stewart

Guru
Joined
Sep 16, 2009
Messages
603
Reaction score
6
Just checked another box and it shows:
lrwxrwxrwx 1 asterisk asterisk 62 Oct 22 17:33 source-SugarCRM.php -> /var/www/html/admin/modules/superfecta/bin/source-SugarCRM.php
lrwxrwxrwx 1 asterisk asterisk 70 Oct 22 17:33 source-Superfecta_Cache.php -> /var/www/html/admin/modules/superfecta/bin/source-Superfecta_Cache.php
lrwxrwxrwx 1 asterisk asterisk 64 Oct 22 17:33 source-Telco_Data.php -> /var/www/html/admin/modules/superfecta/bin/source-Telco_Data.php

I'm not thinking permissions, but are those pointers or something that should be there?
 

Stewart

Guru
Joined
Sep 16, 2009
Messages
603
Reaction score
6
Nope. We've done a several customizations, but nothing in this area.

I'm now using the new one you posted. The interesting thing is that I still see the drop-down and not check boxes. Strange...
 

Stewart

Guru
Joined
Sep 16, 2009
Messages
603
Reaction score
6
OK. Got it. I was looking in the wrong place. For some reason I was looking at
/var/lib/asterisk/bin/source-SugarCRM.php
instead of
/var/www/html/admin/modules/superfecta/bin/source-SugarCRM.php

It works now with the first update you gave. Thanks!
 

riverman

New Member
Joined
Aug 29, 2010
Messages
2
Reaction score
0
Blocking SPAM calls

Hi,
After I installed a new server with SuperFecta no SPAM-calls are blocked anymore. I've tried to search for a solution but can't find any.

Is it possible to block calls with SPAM-flag?
 

candrews

New Member
Joined
Jan 25, 2011
Messages
4
Reaction score
0
CallerID web service

I really wanted Caller ID available to my OpenWRT Asterisk system, and it seems impossible to install CallerID Superfecta on it, so I had to do something different. My other motivation was that I wanted to make an Android app to provide Caller ID for incoming calls, and I couldn't find a service that my app could use... so I had to make one. (BTW - the source for the app is here: https://gitorious.org/callerid-for-android it's not yet on the Android market.)
I also didn't like how CallerID Superfecta processes lookups serially, meaning that one slow source can cause a serious delay. So I created my own project which provides a simple web service that takes a phone number and returns the Caller ID. I translated a few of the US Superfecta sources to my new service as a start.
My service's source is available at https://gitorious.org/callerid-service licensed under the AGPLv3 license. It's very easy to install and configure, and I intend to add more sources and more features (such as spam checking, physical address lookup, and more) - and I'd love contributions.
To tie it into Asterisk, you'd add something like this to extensions.conf:
exten => SOMETHING, n, Set(CALLERID(name)=${CURL(http://192.168.0.101/callerid/callerid.php?format=basic&num=${CALLERID(num)})})
Thank you, awesome CallerID Superfecta community!
 

tm1000

Schmoozecom INC/FreePBX
Joined
Dec 1, 2009
Messages
1,360
Reaction score
78
Uhhh....????

Thanks for forking. I mean it's cool because it's all open source and you can do what you what. But it would have been nice to have your help with the hosted project here. You could have been a developer and helped and that would have been really cool and helpful to the project.

In fact the next version already is doing unserialized lookups. It's in beta and doesn't need the callerid freepbx program and you'd never have to enter passwords and such because it modifies the dialplan real time.

Plus we were in the planning stages of writing a community version like you have written and if you would have spent the time to look at our project site you would have seen that.

I don't mean to be mean it's just we have lots of people who've put in tons of time to make the project great and I don't understand why you couldn't have been one of them or emailed or privated messaged any one of us for help (me,lgaetz,tshif,ward,darmock,etc.).

Also you've got some legal issues on your hands here. Your authors file does state "Many (if not all) of the sources came from CallerID Superfecta: http://projects.colsolgrp.net/projects/superfecta". However according to GPL you need to keep the GPL license in-tact if you took any of the source code from the project (eg forking):

http://www.gnu.org/licenses/gpl.html said:
a) The work must carry prominent notices stating that you modified it, and giving a relevant date.
b) The work must carry prominent notices stating that it is released under this License and any conditions added under section 7. This requirement modifies the requirement in section 4 to “keep intact all notices”.
c) You must license the entire work, as a whole, under this License to anyone who comes into possession of a copy. This License will therefore apply, along with any applicable section 7 additional terms, to the whole of the work, and all its parts, regardless of how they are packaged. This License gives no permission to license the work in any other way, but it does not invalidate such permission if you have separately received it.
d) If the work has interactive user interfaces, each must display Appropriate Legal Notices; however, if the Program has interactive interfaces that do not display Appropriate Legal Notices, your work need not make them do so.

Anyways glad you got it all worked out and glad you got the project to work on your server. Your code looks great.

And I'm seriously not trying to be mean. I just think I'm upset that you forked the whole project instead of helping to make it better and helping to break it out of FreePBX which is what the 10 or so developers have stated they want to do. You never even brought these concerns up....
 

candrews

New Member
Joined
Jan 25, 2011
Messages
4
Reaction score
0
Forking? Not intentionally, at least

As lgaetz notes, I didn't see answers to my previous questions, and was not aware of the next version of Superfecta would more closely aligns with my needs. Also, notably, I have an account on the development site, and have submitted one (small) issue with a new source. If I was aware, I probably would have joined - and I have certainly not excluded the possibility of doing so! I think of forking as a last resort, an option that's great to have but should be avoided. I thought the Superfecta project was tightly coupled to FreePBX, bound to work on very old versions of PHP (4.x), and in maintenance mode (I looked around, and didn't see any signs of active development). Therefore, my goals seemed very different from the Superfecta project, and therefore a new project could fill a new niche, and not be a fork at all. Clearly, I was wrong on those points.

With this knowledge, I plan to look over the code for the next version of Superfecta. I didn't notice it before as the v3.0.0.x branch hasn't been modified in a while, so I thought it was a stagnant and/or abandoned effort.

Regarding licensing, I'm a big Free Software advocate (notice my work is all (A)GPL licensed and hosted on gitorious - not github), and tend to pay decent attention to licensing. I noticed the GPL license in the "disclaimer.html" file, which is awesome - I simply re-licensed to AGPLv3 instead (which is fine in terms of licensing to do). I felt this was a better means of protecting my work. I believe I complied with the GPL terms as pointed out by tm1000 via my file headers, source control history, and LICENSE/README files. However, I'm not a jerk - if you're not happy with my means of compliance, please let me know what I can do to make you happy, and I'll do it.

I would love to have my CallerID service grow a community, or to become a part of Superfecta and its community. I'm not terribly excited about maintaining scrapers, and I'm especially cognitive of how much harder it will be to maintain/develop scrapers for countries I'm not familiar with. If Superfecta and my project do end up destined not to be one, I'd love if, at least, we could share scrapers.

I've already added address and company information to the results returned by my service. I'm currently using this information in my Android app (which is GPLv3, and pretty useful IMHO). I'm hoping to add more scrapers and also spam likelihood information to the results going forward.
 

luckman212

Guru
Joined
Jul 7, 2010
Messages
272
Reaction score
0
don't know if the horse has already left the barn but I just noticed that the "Send to YAC" module (which I use for screen pops) does not send anything if CALLERID(name) is null. So if some number dials in that doesn't return anything, I don't get the screen pop.

Would be good if it at least passed "Unknown - 2126666666" etc.
 

luckman212

Guru
Joined
Jul 7, 2010
Messages
272
Reaction score
0
Nope, it won't send the number out if CNAM is null. I made a quick & dirty patch, works for me! (source attached) Just extract & drop into /var/www/html/admin/modules/superfecta/bin
:smile5:

[root@pbx bin]# diff source-Send_to_YAC.php source-Send_to_YAC2.php
21c21,25
< if (($run_param['Server_address'] !='') && ($first_caller_id != ''))
---
> if ($first_caller_id == '')
> {
> $first_caller_id = 'Unknown';
> }
> if (($run_param['Server_address'] !='') && ($thenumber != ''))
28c32
< print 'Send to YAC: '.$first_caller_id.' '.$thenumber.'<br><br>';
---
> print 'Send to YAC2: '.$first_caller_id.' '.$thenumber.'<br><br>';
32c36
< ?>
\ No newline at end of file
---
> ?>
 

Attachments

  • source-Send_to_YAC2.zip
    1,019 bytes · Views: 0

luckman212

Guru
Joined
Jul 7, 2010
Messages
272
Reaction score
0
Yes your solution is probably a bit safer, but I'm too lazy to go change it again :smile5: I have my YAC as the very last module in the chain so my patch should not "break" anything but of course YMMV.
 

luckman212

Guru
Joined
Jul 7, 2010
Messages
272
Reaction score
0
Sorry, did not mean to be lazy in that way.. I meant I am lazy when it comes to myself! OK I have tested your new patch and there's one bug:

change
$yac_text = $first_caller_id.'~'.$thenumber;

to
$yac_text = $yac_cnam.'~'.$thenumber;

then it works great!!:smile5:
 

Members online

Forum statistics

Threads
25,770
Messages
167,441
Members
19,181
Latest member
ejrubin
Get 3CX - Absolutely Free!

Link up your team and customers Phone System Live Chat Video Conferencing

Hosted or Self-managed. Up to 10 users free forever. No credit card. Try risk free.

3CX
A 3CX Account with that email already exists. You will be redirected to the Customer Portal to sign in or reset your password if you've forgotten it.
Top